Skip to content

Fix: changing request_queue_id everytime!#13

Merged
amindadgar merged 2 commits intomainfrom
fix/8-urls-limit
Apr 2, 2025
Merged

Fix: changing request_queue_id everytime!#13
amindadgar merged 2 commits intomainfrom
fix/8-urls-limit

Conversation

@amindadgar
Copy link
Member

@amindadgar amindadgar commented Apr 2, 2025 •
edited by coderabbitai bot
Loading

the reason is, crawlee is caching all the requests and everytime it's being re-initialized, it would re-fetch previous enqueud links and not the new ones
still no good way of removing the request_queue is not provided by crawlee community.

Summary by CodeRabbit

  • New Features
    • Enhanced the crawler’s startup behavior so each session begins fresh without carrying over data from previous runs. This improvement ensures that every new crawl uses a unique configuration, contributing to more accurate and isolated crawling sessions.

@amindadgar
fix: changing request_queue_id in every init!
3f59b92 
the reason is, crawlee is caching all the requests and everytime it's being re-initialized, it would re-fetch previous enqueud links and not the new ones
still no good way of removing the request_queue is not provided by crawlee community.
@amindadgar
fix: black linter issues!
2f0fcc7
@amindadgar amindadgar linked an issue Apr 2, 2025 that may be closed by this pull request
BUG: limited to extract websites #8
Closed
@coderabbitai
Copy link

coderabbitai bot commented Apr 2, 2025 •
edited
Loading

Walkthrough

This pull request updates the initialization process of the crawler in the CrawleeClient class by adding a UUID-generated request queue identifier and setting a new configuration option (purge_on_start) to True. Additionally, the test file has been reformatted to improve readability without altering its behavior.

Changes

File(s) Change Summary
hivemind_etl/website/crawlee_client.py Added import uuid; updated the CrawleeClient initialization to include a purge_on_start configuration and assign a unique default_request_queue_id using uuid.uuid4().hex.
tests/unit/test_website_etl.py Reformatted the with patch statement in the test_extract method from a single-line to a multi-line format for improved readability.

Sequence Diagram(s)

sequenceDiagram
    participant Client as CrawleeClient
    participant UUID as uuid.uuid4
    Client->>Client: Initialize with configuration
    Note right of Client: Set purge_on_start = True
    Client->>UUID: Generate unique queue ID
    UUID-->>Client: Return new UUID (hex)
    Client->>Client: Assign default_request_queue_id
Loading

Possibly related PRs

Poem

I'm a rabbit in a digital glen,
Hopping with joy, I code again.
New UUIDs whisper in the breeze,
Purge on start, a change to please.
Hop along, dear code, with glee!
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 83ad0ac and 2f0fcc7.

📒 Files selected for processing (2)
  • hivemind_etl/website/crawlee_client.py (2 hunks)
  • tests/unit/test_website_etl.py (1 hunks)
🧰 Additional context used
🧬 Code Definitions (1)
tests/unit/test_website_etl.py (2)
hivemind_etl/website/crawlee_client.py (1)
  • crawl (85-123)
hivemind_etl/website/website_etl.py (1)
  • extract (31-64)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: ci / lint / Lint
  • GitHub Check: ci / test / Test
🔇 Additional comments (4)
tests/unit/test_website_etl.py (1)

33-43: Formatting improvements look good!

The multi-line formatting of the with patch statement and the addition of blank lines improve code readability while maintaining the original test functionality.

hivemind_etl/website/crawlee_client.py (3)

3-3: Appropriate import added for UUID generation

The uuid module import is necessary for creating unique request queue identifiers.

25-25: Good configuration to purge data on start

Setting purge_on_start to True ensures that any existing cache data is cleared when the crawler starts, which helps prevent issues with stale data.

27-30: Effective solution for preventing request cache issues

Using a unique UUID for the default_request_queue_id ensures that each crawler instance uses a different request queue, preventing the re-fetching of previously enqueued links. The comments clearly explain the purpose of this change.

This implementation effectively addresses the problem described in the PR objectives where the Crawlee library was caching requests and there was no effective method to remove the request queue.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@amindadgar amindadgar merged commit bb5c53a into main Apr 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BUG: limited to extract websites

1 participant

@amindadgar